Submission Details
Severity:
[L-1] `CharityRegistry::isVerified` Should Indicate Unverified Status
Description:
The CharityRegistry::isVerified function allows users to check if a charity is verified, but it does not provide feedback when the charity is unverified. As a result, users may be left uncertain when no verification status is returned.
Impact:
This lack of feedback can lead to poor user experience. Users currently only know a charity is verified if CharityRegistry::isVerified returns true. In the absence of a response, users may have to guess, creating uncertainty about the charity’s status.
Proof of Code:
The following test code illustrates that CharityRegistry::isVerified currently returns output only for verified charities, leaving unverified ones ambiguous:
function test_isVerified() public {
address charity_address = address(1);
registryContract.registerCharity(charity_address);
bool is_Charity_Registered = registryContract.isVerified(charity_address);
assertTrue(is_Charity_Registered, "Expected to verify after registration");
address charity_address_two = address(2);
bool is_Charity_NotRegistered = registryContract.isVerified(charity_address_two);
assertFalse(is_Charity_NotRegistered, "Charity expected to be unverified");
}
Since the test passed, CharityRegistry::isVerified function is correctly distinguishing between registered and unregistered addresses without throwing errors. This is important for user experience, as it lets users check if an address is verified without triggering reverts. The test ensures the contract logic aligns with your intended behavior.
Tools Used:
Foundry
Recommended Mitigation:
Implement a require statement in isVerified to notify users when a charity is not verified:
function isVerified(address charity) public view returns (bool) {
require(registeredCharities[charity], "Charity is not verified");
return registeredCharities[charity];
}
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.