Submission Details
Severity:
The donor can donate to a charity that is not verified by admin
Summary
When a donor calls the 'GivingThanks::donate' function, the function will check if the charity is verified. However, the 'CharityRegistry::verifyCharity' function does not check if the charity is verified by the admin, only if the charity has been registered.
Vulnerability Details
Proof of concept
The test 'GivingThanks::testCannotDonateToUnverifiedCharity' proves () that the 'CharityRegistry::verifyCharity' function does not check if the charity is verified by the admin, only if the charity has been registered.
Impact
Any registered address can receive donations, so the admin role would lose control over whether or not to allow donations, compromising the reliability of the protocol.
Tools Used
Foundry, Manual Code Review
Recommendations
The 'CharityRegistry::isVerified' function should be used to check if the charity is a verified charity by the admin.
``` diff
function isVerified(address charity) public view returns (bool) {
- return registeredCharities[charity];
+ return registeredCharities[charity] && verifiedCharities[charity];
}
```
Updates
Lead Judging Commences
n0kto 12 months ago
Submission Judgement Published Assigned finding tags:
finding-isVerified-return-registered-charities
Likelyhood: High, the function returns registered charities instead of verified ones. Impact: High, Any charities can be registered by anyone and will be declared as verified by this function bypassing verification.
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.