Submission Details
Severity:
Wrong param (msg.sender instead of _registry) assign to `GivingThanks:registry`
**Description:** In the constructor of `GivingThanks`, the `registry` is assigned to the `msg.sender` instead of `_registry`,
which blocks `GivingThanks:donate` function since it contains `registry.isVerified(charity)`.
```javascript
constructor(address _registry) ERC721("DonationReceipt", "DRC") {
// @audit-high: wrong param pass in, should be _registry instead of msg.sender
@> registry = CharityRegistry(msg.sender);
owner = msg.sender;
tokenCounter = 0;
}
```
**Impact:** The `GivingThanks:donate` function is blocked
**Proof of Concept:** place the following into `GivingThanks.t.sol`.
```javascript
function testWrongCharityRegistryPassing() public view {
assertNotEq(address(charityContract.registry()), address(registryContract));
}
```
**Recommended Mitigation:**
in `GiveThanks.sol`
```diff
constructor(address _registry) ERC721("DonationReceipt", "DRC") {
// @audit-high: wrong param pass in, should be _registry instead of msg.sender
- registry = CharityRegistry(msg.sender);
+ registry = CharityRegistry(_registry);
owner = msg.sender;
tokenCounter = 0;
}
```
Updates
Lead Judging Commences
n0kto 12 months ago
Submission Judgement Published Assigned finding tags:
finding-bad-registry-set-at-construction
Likelyhood: High, the parameter is not well used and won't be set. Impact: Low, can be changed with the setter and no one will be able to donate to malicious charity.
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.