GivingThanks

First Flight #28
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

Missing access control to `GivingThanks::updateRegistry` function

Summary

The GivingThanks::updateRegistry function allows anyone to assign any address to the registry because the onlyOwner modifier is not used.

Vulnerability Details

Due to the lack of access control in GivingThanks::updateRegistry anyone can assign any address to registry, opening the door to linking a malicious contract controlled by an attacker.

Impact

Allows to redirect donations to addresses controlled by an attacker.

Tools Used

Foundry, Remix

Recommendations

Restrict access to the GivingThanks::updateRegistry function using the onlyOwner modifier.

Updates

Lead Judging Commences

n0kto Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-anyone-can-change-registry

Likelyhood: High, anyone can change it at anytime Impact: High, can bypass the verification process

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.