Submission Details
Severity:
Token Counter Incremented After Minting
Summary
In the GivingThanks::donate function, the token counter is incremented after the token has been created, not following the Checks-Effects-Interactions pattern.
Vulnerability Details
The token counter is incremented after the token has been created regardless of whether the transaction was successful or not.
Impact
It can lead to inconsistencies in the contract states.
Tools Used
Foundry, Remix
Recommendations
The counter should be incremented before creating the token, following the Checks-Effects-Interactions pattern.
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.