GivingThanks

Root Cause and Impact

• Root Cause: The isVerified function returns the status of registeredCharities instead of verifiedCharities.

• Impact: Unverified charities that are merely registered can receive donations, bypassing the intended verification process and allowing potential fraud.

Vulnerability Details

• Incorrect isVerified Function:

  function isVerified(address charity) public view returns (bool) {

  return registeredCharities[charity];

  }

  • Issue: Checks registeredCharities instead of verifiedCharities.

  • Consequence: Any registered charity is considered verified.

Recommendations

• Correct the Function to Check verifiedCharities:

  function isVerified(address charity) public view returns (bool) {

  return verifiedCharities[charity];

  }

• Ensure Proper Workflow for Charity Verification:

  • Only allow verified charities to receive donations.

  • Maintain clear separation between registration and verification statuses.