Submission Details
Severity:
Use of msg.sender instead of _registry
Summary
constructor(address _registry) ERC721("DonationReceipt", "DRC") {
registry = CharityRegistry(msg.sender); // this is a bug intendted to add _registry here
tokenCounter = 0;
}
Vulnerability Details
Impact
The contract will not compile because of a bug in the constructor
Tools Used
Mannul Review
Recommendations
Replace the msg.sender with the _registry argument
constructor(address _registry) ERC721("DonationReceipt", "DRC") {
registry = CharityRegistry(_registry); // this is a bug intendted to add _registry here
tokenCounter = 0;
}
Updates
Lead Judging Commences
n0kto 12 months ago
Submission Judgement Published Assigned finding tags:
finding-bad-registry-set-at-construction
Likelyhood: High, the parameter is not well used and won't be set. Impact: Low, can be changed with the setter and no one will be able to donate to malicious charity.
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.