Incorrect Registry Address
Summary
The incorrect address is being used to configure the registry.
Vulnerability Details
In GivingThanks.sol, on line 16 the registry is being configured. However, the incorrect addess is being used to configure the registry variable. Here msg.sender is being used instead of the correct address which is the _registry parameter.
Impact
This means that no one will be able to donate because all calls to donate() will revert due to the check on line 22 calling isVerified() on the incorrect address.
Tools Used
Manual Review
Recommendations
Update line 16 to read registry = CharityRegistry(_regisrty).
Lead Judging Commences
finding-bad-registry-set-at-construction
Likelyhood: High, the parameter is not well used and won't be set. Impact: Low, can be changed with the setter and no one will be able to donate to malicious charity.
Rewards breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.