Incorrect Check For Verified Addresses
Summary
An incorrect check is being used to verify addresses in the isVerified() function.
Vulnerability Details
In CharityRegistry.sol on line 24 an incorrect check is being used to verify addresses. Here the registeredCharities mapping is being used which returns whether the chairty is registered and not whether it has actually been verified.
Impact
This means that an attacker could register a malicious charity, and all calls to isVerified() for that chairty will return true bypssing the verification processes.
Tools Used
Manual Review
Recommendations
Update line 24 to read return verifiedCharities[charity].
Lead Judging Commences
finding-isVerified-return-registered-charities
Likelyhood: High, the function returns registered charities instead of verified ones. Impact: High, Any charities can be registered by anyone and will be declared as verified by this function bypassing verification.
Rewards breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.