GivingThanks

Summary

In CharityRegistry contract we have a function called isVerified which is used to check if the charity is verified before donating. But isVerified will always return true if the charity is registered as we are using registeredCharities[charity] check to verify the charity instead of verifiedCharities[charity].

Vulnerability Details

In the isVerified function, we are using incorrect mapping to check if the charity is verified or not. We should be using verifiedCharities[charity] instead of registeredCharities[charity].

Impact

isVerified will always return true if the charity is registered allowing the malicious actor to register the malicious charity contract and steal all the donations.

Tools Used

Manual review and foundry.

Recommendations

Replace registeredCharities[charity] with verifiedCharities[charity].