GivingThanks

First Flight #28
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

Smart Contract Security Analysis Report

Vulnerability: Missing Verification in isVerified Function

Date: 13.11.2024

Severity: Medium

Description:
In the CharityRegistry contract, the isVerified function returns the value of registeredCharities[charity] instead of verifiedCharities[charity]. This could result in unverified charities being treated as verified, potentially allowing donors to send Ether to unverified addresses and receive donation receipt NFTs.

Mitigation:
Ensure the isVerified function checks the correct mapping:

function isVerified(address charity) public view returns (bool) {
return verifiedCharities[charity];
}
Updates

Lead Judging Commences

n0kto Lead Judge 10 months ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-isVerified-return-registered-charities

Likelyhood: High, the function returns registered charities instead of verified ones. Impact: High, Any charities can be registered by anyone and will be declared as verified by this function bypassing verification.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.