GivingThanks

First Flight #28
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

donate() can allow donation by any users since isVerified() will always return true.

Summary

We are returing registeredCharities[charity] in isVerified() which will always return true and due to this donor can donate to unverified charities.

Vulnerability Details

Impact

Tools Used

Recommendations

Update isVerified() to return only verified charities, as:verifiedCharities

function isVerified(address charity) public view returns (bool) {
return verifiedCharities[charity];
}
Updates

Lead Judging Commences

n0kto Lead Judge 8 months ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-isVerified-return-registered-charities

Likelyhood: High, the function returns registered charities instead of verified ones. Impact: High, Any charities can be registered by anyone and will be declared as verified by this function bypassing verification.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.