Submission Details
Severity:
Missing Access Control Inheritance
Summary
The owner variable is defined but not utilized effectively in the GivingThanks contract.
Vulnerability Details
The contract lacks standardized access control functionality for owner-specific functions.
https://github.com/Cyfrin/2024-11-giving-thanks/blob/main/src/GivingThanks.sol#L10
contract GivingThanks is ERC721URIStorage {
Impact
Lack of proper ownership control can make managing the contract’s administrative functions cumbersome and error-prone.
Tools Used
Manual review
Recommendations
Inherit from OpenZeppelin’s Ownable contract to simplify access control:
contract GivingThanks is ERC721URIStorage, Ownable { ... }
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.