GivingThanks

First Flight #28
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: low
Invalid

Lack of Event Emission for Key State-Changing Functions

Summary

Both CharityRegistry and GivingThanks contracts lack event emissions for key state-changing functions. Event emissions are essential for logging important actions on the blockchain, enabling better tracking, monitoring, and debugging. Without events, it is challenging to verify contract behavior and monitor important actions, such as charity registrations, verifications, donations, and administrative updates.

Vulnerability Details

A lot of functions in this protocol change contract state or transfer assets without emitting events. Without events, tracking these changes becomes difficult, which could result in data loss or lack of transparency in case of disputes or audits.

Impact

The lack of event emissions can lead to:

  • Reduced Transparency: Key actions, such as charity verifications, donations, and administrative updates, cannot be tracked efficiently. This makes it harder for participants or external auditors to verify contract operations.

  • Challenges in Debugging and Monitoring: Without events, it is challenging to monitor or debug the contract’s behavior, which could delay detection of unexpected behavior or misuse.

  • Reduced Trustworthiness: Users may lose confidence in the platform if they cannot easily verify that their actions (like donations) were processed as expected.

Tools Used

Manual Review

Recommendations

Add events to log key actions in both contracts to improve transparency and traceability.

Updates

Lead Judging Commences

n0kto Lead Judge 8 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.