Submission Details
Severity:
Registry could be replaced by anyone
Summary
There is no access control forGivingThanks::updateRegistry(address), registry contract could be manipulated by anyone.
Vulnerability Details
GivingThanksuses CharityRegistryas reference to check verified charities. However, GivingThanks::updateRegistryis public and able to be changed the reference by anyone else.
function updateRegistry(address _registry) public {
registry = CharityRegistry(_registry);
}
Impact
CharityRegistry could be manipulated and doner might send money to unverified charities.
Tools Used
Recommendations
function updateRegistry(address _registry) public {
+ require(admin == msg.sender, "Only Admin can change");
registry = CharityRegistry(_registry);
}
Updates
Lead Judging Commences
n0kto about 1 year ago
Submission Judgement Published Assigned finding tags:
finding-anyone-can-change-registry
Likelyhood: High, anyone can change it at anytime Impact: High, can bypass the verification process
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.