Submission Details
Severity:
tokenCounter minted for donaters are not suitable
Summary
tokenCounter minted for donaters are not suitable.
Vulnerability Details
This contract take tokenCounter as the token number minted for every donater, tokenCounter is the total count in fact. So, later donaters will get more tokens.
https://github.com/Cyfrin/2024-11-giving-thanks/blob/main/src/GivingThanks.sol#L26
function donate(address charity) public payable {
...
_mint(msg.sender, tokenCounter);
...
tokenCounter += 1;
}
Impact
later donaters will get more tokens, it is unfair.
Tools Used
manually review.
Recommendations
set token number minted for each donate to 1, or a constant ratio to msg.value.
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.