Summary

Instead of marking a function as public, consider marking it as external if it is not used internally.

Vulnerability Details

The following functions should be marked as external

• src/CharityRegistry.sol Line: 13

  function registerCharity(address charity) public {

• src/CharityRegistry.sol Line: 17

  function verifyCharity(address charity) public {

• src/CharityRegistry.sol Line: 24

  function isVerified(address charity) public view returns (bool) {

• src/CharityRegistry.sol Line: 29

  function changeAdmin(address newAdmin) public {

• src/GivingThanks.sol Line: 27

  function donate(address charity) public payable {

• src/GivingThanks.sol Line: 63

  function updateRegistry(address _registry) public {

Tools Used

Aderyn

Recommendations

Mark the above functons as external instead of public