Submission Details
Severity:
Refactor `GivingThanks::donate` function to follow CEI pattern to avoid a potential event reentrancy attack
Summary
Refactor the GivingThanks::donate function to follow the CEI pattern (Checks, Effects, Interactions) Pattern to avoid potential event reentrancy attack
Recommendations
function donate(address charity) public payable {
// Checks
require(registry.isVerified(charity), "Charity not verified");
(bool sent,) = charity.call{value: msg.value}("");
require(sent, "Failed to send Ether");
// Effects
string memory uri = _createTokenURI(msg.sender, block.timestamp, msg.value);
_setTokenURI(tokenCounter, uri);
tokenCounter += 1;
// Interactions
_mint(msg.sender, tokenCounter);
}
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.