Submission Details
Severity:
Require Owner in `updateRegitry` function.
Vulnerability Details
In GivingThanks.sol, if this function is not restricted to onlyowner modifier or msg.sender requirement, anyone can update address as this is a public function.
function updateRegistry(address _registry) public {
registry = CharityRegistry(_registry);
}
Impact
Anyone/malicious actor can
updateRegisteryand then calldonatefunction which will lead to loss of fundsAlso it'll impact the integrity & trust.
Tools Used
Manual Review
Recommendations
Use OpenZeppelin’s Ownable.sol for Admin Management.
function updateRegistry(address _registry) public onlyOwner {
registry = CharityRegistry(_registry);
}
Or Use Require Check.
function updateRegistry(address _registry) public {
require(msg.sender == admin, "only admin can update registry")
registry = CharityRegistry(_registry);
}
Updates
Lead Judging Commences
n0kto 7 months ago
Submission Judgement Published Assigned finding tags:
finding-anyone-can-change-registry
Likelyhood: High, anyone can change it at anytime Impact: High, can bypass the verification process
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.