Submission Details
Severity:
Access Control on updateRegistry()
Summary
function
updateRegistrycan be called by anybody, no restriction in place.
Vulnerability Details
Anybody can call the function and change registry address.
If an attacker calls the function, it can change the address to a malicious contract.
function updateRegistry(address _registry) public {
registry = CharityRegistry(_registry);
}
Impact
ETH won't be donated to registry address as intended.
Tools Used
Manual Review
Recommendations
Add restriction to the function, onlyOwner.
function updateRegistry(address _registry) public onlyOwner {
registry = CharityRegistry(_registry);
}
Updates
Lead Judging Commences
n0kto 7 months ago
Submission Judgement Published Assigned finding tags:
finding-anyone-can-change-registry
Likelyhood: High, anyone can change it at anytime Impact: High, can bypass the verification process
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.