GivingThanks

First Flight #28
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: medium
Invalid

Admin Role Changes Should Be Two Step

Summary

GivingThanks uses Single-step ownership transfer which can be dangerous.

Vulnerability Details

The admin address carries numerous important abilities for the system.
However the changeAdmin function allows the admin address to be errantly transferred to the wrong address as it does not use a two-step transfer process.

https://github.com/Cyfrin/2024-11-giving-thanks/blob/304812abfc16df934249ecd4cd8dea38568a625d/src/CharityRegistry.sol#L27

Impact

protocol will be bricked

Tools Used

manual

Recommendations

Implement a two step “push” and “pull” admin transfer process.

Updates

Lead Judging Commences

n0kto Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.