Submission Details
Severity:
Unused Parameter
Summary
Unused Parameter should be removed or comment out.
Vulnerability Details:
Issue Description:
As there is unused parameter in constructor _registry which has following issues:
can increase gas cost
not a good practice
not effective for code cleanliness
constructor(address _registry) ERC721("DonationReceipt", "DRC") {
registry = CharityRegistry(msg.sender);
owner = msg.sender;
tokenCounter = 0;
}
If it is necessary to use then the code should be like this:
constructor(address _registry) ERC721("DonationReceipt", "DRC") {
registry = CharityRegistry(_registry);
owner = msg.sender;
tokenCounter = 0;
}
Otherwise remove the unused parameter, and the code will be:
constructor() ERC721("DonationReceipt", "DRC") {
registry = CharityRegistry(msg.sender);
owner = msg.sender;
tokenCounter = 0;
}
Impact:
Unused variable increase gas cost
Tools Used:
Manual review
Recommendations:
Remove the unused variable.
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.