Submission Details
Severity:
No Revert on Re-registration in CharityRegistry::registerCharity() function
Summary
The lack of re-registration checks can lead to data integrity issues and potential exploitation, which can be mitigated by adding a simple check in the registration function.
Vulnerability Details
The registerCharity function allows any address to be registered as a charity without checks. Re-registration of an already registered charity address is possible, which can overwrite previous state without any warning or error.
Impact
Re-registration can lead to confusion or errors in tracking which charities are newly registered.
Tools Used
Manual Review
Recommendations
Implementation of check that charity already registered
function registerCharity(address charity) public {
require(!registeredCharities[charity], "Charity already registered");
registeredCharities[charity] = true;
}
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.