Project
One World
NFTDeFi
15,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Requre minimum value validation in TierPrice

ashishlach

Summary

If Tier price is less than or equal to 4 then below logic will not work. Platform fees will be 0. Validation required in updateDAOMembership() function when accepting tier price.

uint256 platformFees = (20 * tierPrice) / 100;
​

Vulnerability Details

Platform fees will not be given for lower priced tiers

https://github.com/Cyfrin/2024-11-one-world/blob/1e872c7ab393c380010a507398d4b4caca1ae32b/contracts/dao/MembershipFactory.sol#L144

Impact

Contract will not receive platform fees as it intended to

Tools Used

Manual review

Recommendations

Minimum validation required in updateDAOMembership() function when accepting tier price to make sure platform fees are paid

Updates

Lead Judging Commences

0xbrivan2 Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.