Submission Details
Severity:
MembershipERC1155.sol is not EIP-1155 compliant
Summary
MembershipERC1155.sol does not follow the URI specifications of EiP-1155.
Vulnerability Details
The contract supports IERC1155MetadataURI through AccessControlUpgradeable.
function supportsInterface(bytes4 interfaceId) public view virtual override(ERC165Upgradeable, IERC165) returns (bool) {
return
interfaceId == type(IERC1155).interfaceId ||
interfaceId == type(IERC1155MetadataURI).interfaceId ||
super.supportsInterface(interfaceId);
}
As a result, it has to conform to the EIP-1155 expectations.
Particularly,
Changes to the URI MUST emit the URI event if the change can be expressed with an event (i.e. it isn’t dynamic/programmatic).
setURI() doesn't emit an event.
function setURI(string memory newURI) external onlyRole(DAO_CREATOR) {
_setURI(newURI);
}
Impact
Not EIP-1155 compliant
Tools Used
Manual Review
Recommendations
Follow the EIP-1155 specifications
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
54128 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.