Project

One World
NFTDeFi
15,000 USDC
View results
Submission Details
Severity: low
Invalid

Lack of Event Emission for Updates in updateDAOMembership

Summary:

The updateDAOMembership function lacks event emission after updating the DAO configuration. This can reduce transparency and make it difficult to track changes on-chain.

Vulnerability Details:


The updateDAOMembership function lacks event emission after updating the DAO configuration. This can reduce transparency and make it difficult to track changes on-chain.

Impact:

This impacts the contract’s transparency, making it difficult for off-chain services and DAO members to monitor changes.

Tools Used:

Manual Review

Recommendations:

Emit a DAOMembershipUpdated event at the end of updateDAOMembership, logging the DAO address, ENS name, number of tiers, and maxMembers value. This event will improve the function’s transparency and help track changes on-chain.

event DAOMembershipUpdated( address indexed daoAddress, string ensName, uint256 newNoOfTiers, uint256 maxMembers );
emit DAOMembershipUpdated(daoAddress, ensName, dao.noOfTiers, dao.maxMembers);
Updates

Lead Judging Commences

0xbrivan2 Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
0xbrivan2 Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.