Project
One World
NFTDeFi
15,000 USDC
View results
Previous Next
Submission Details
Severity: medium
Invalid

`OWPIdentity` implements ERC-1155 but doesnt follow the corresponding EIP

rhaydden

Description

OWPIdentity::setURI updates the token's URI without emitting the required URI event. This violates the ERC-1155 metadata extension spec which the OWPIdentity contract heavily depends on which mandates that all URI changes must emit an event.

Link:

function setURI(string memory newuri) public onlyRole(DEFAULT_ADMIN_ROLE) {
_setURI(newuri);
}

From EIP-1155:

Changes to the URI MUST emit the URI event if the change can be expressed with an event (i.e. it isn't dynamic/programmatic).

Key word here is "MUST" and according to RFC 2119:

MUST: This word, or the terms "REQUIRED" or "SHALL", mean that the definition is an absolute requirement of the specification.

Recommendation

Consider modifying setURI to emit the URI event after updating the base URI

Updates

Lead Judging Commences

0xbrivan2 Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!