Project
One World
NFTDeFi
15,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Missing Event Emission in updateDAOMembership Function

calc1f4r

Summary

The updateDAOMembership function is responsible for updating the tier configurations of a DAO. However, it does not emit an event to notify off-chain systems or users about this critical state change. Emitting events for significant operations is a best practice in smart contract development as it enhances transparency and facilitates efficient monitoring.

Impact:

Transparency: Users and off-chain services are unable to track updates to DAO memberships effectively.

Recommendations

Define an Event: Introduce a new event, such as MembershipDAOUpdated, that captures relevant details of the update operation.

event MembershipDAOUpdated(string indexed ensName, address daoAddress, DAOConfig daoData);

Emit the Event: At the end of the updateDAOMembership function, emit the event with appropriate parameters.

function updateDAOMembership(
string calldata ensName,
TierConfig[] memory tierConfigs
) external onlyRole(EXTERNAL_CALLER) returns (address) {
address daoAddress = getENSAddress[ensName];
require(tierConfigs.length <= TIER_MAX, "Invalid tier count.");
require(tierConfigs.length > 0, "Invalid tier count.");
require(daoAddress != address(0), "DAO does not exist.");
DAOConfig storage dao = daos[daoAddress];
if (dao.daoType == DAOType.SPONSORED) {
require(tierConfigs.length == TIER_MAX, "Invalid tier count.");
}
​
uint256 maxMembers = 0;
​
// Preserve minted values and adjust the length of dao.tiers
for (uint256 i = 0; i < tierConfigs.length; i++) {
if (i < dao.tiers.length) {
tierConfigs[i].minted = dao.tiers[i].minted;
}
}
​
// Reset and update the tiers array
delete dao.tiers;
for (uint256 i = 0; i < tierConfigs.length; i++) {
dao.tiers.push(tierConfigs[i]);
maxMembers += tierConfigs[i].amount;
}
​
// updating the ceiling limit acc to new data
if (maxMembers > dao.maxMembers) {
dao.maxMembers = maxMembers;
}
​
dao.noOfTiers = tierConfigs.length;
+ emit MembershipDAOUpdated(ensName, daoAddress, dao);
return daoAddress;
}
Updates

Lead Judging Commences

0xbrivan2 Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
0xbrivan2 Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.