Project

One World
NFTDeFi
15,000 USDC
View results
Submission Details
Severity: high
Valid

Users that haven't KYC'd can still create and join DAOs

Summary

The protocol's intention is to not allow anyone to create or join DAOs without first completing the KYC process.

OWPIdentity.sol is an identity contract with the purpose of storing KYC information on users before they can create or join a DAO, but the state of this contract isn't utilized to prevent creating or join DAOs in MembershipFactory.sol.

Vulnerability Details

MembershipFactory::createNewDAOMembership should check to make sure msg.sender owns an OWPIdentity NFT, but it doesn't.

MembershipFactory::joinDAO should check to make sure msg.sender owns an OWPIdentity NFT, but it doesn't.

Impact

You can bypass the front end KYC process and still create a join DAOs by directly calling the functions in MembershipFactory.

Tools Used

Manual review

Recommendations

Check to make sure the caller of createNewDAOMembership and joinDAO have the KYC NFT, otherwise revert.

Updates

Lead Judging Commences

0xbrivan2 Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Appeal created

0xbrivan2 Lead Judge
about 1 year ago
0xbrivan2 Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

KYC is not checked when creating or joining DAOs

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!