Project

Summary

A 20% platform fee is outrageously high, especially in the crypto space. If this disuades people from using the platform (which I believe it will), you may want to lower the platform fee, but you can't because it's hardcoded and MembershipFactoryisn't upgradeable.

Vulnerability Details

Platform fee is hardcoded and MembershipFactory isn't upgradeable:

https://github.com/Cyfrin/2024-11-one-world/blob/1e872c7ab393c380010a507398d4b4caca1ae32b/contracts/dao/MembershipFactory.sol#L144

Impact

You can't update platform fee to something lower, even if you need to for business reasons.

Tools Used

Manual Review

Recommendations

Make platform fee a storage variable and create a setter function that allows admin to update it.