Submission Details
Severity:
During updateDAOMembership function call, it should be validated that 'minted' value does not exceed new 'amount' (max minted amount) values
Summary
During updateDAOMembership function call, it should be validated that minted value does not exceed new amount (max minted amount) values.
Vulnerability Details
It is not validated that the minted value exceeds the amount variable during updating the tiers of a DAO membership.
Impact
This should be validated to ensure the proper amount of tokens can be minted in a specific tier - otherwise minting is blocked for a tier.
Tools Used
Manual review
Recommendations
Add check to updateDAOMembership on MembershipFactory contract:
...
// Preserve minted values and adjust the length of dao.tiers
for (uint256 i = 0; i < tierConfigs.length; i++) {
if (i < dao.tiers.length) {
// @audit
require(tierConfigs[i].amount >= dao.tiers[i].minted);
tierConfigs[i].minted = dao.tiers[i].minted;
}
}
...
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
54128
USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.