Project

Summary

The number of members in a tier can exceed tier.amount due to failure to check for tier amounts when ugrading tiers

Vulnerability Details

The check for tier.minted against tier.amount was introduced in the joinDao function to prevent memberships in a tier from exceeding the defined "amount" limit as a mitigation from a previous audit. However, when upgrading from a previous tier to a new tier theres no check for if the declared "amonut" limit or that tier has been reached. Which can cause more members in a particular tier and Dao to exceed the intended amount.

Impact

There can be excess members in a Dao tier, which goes against the Dao creator's specifications.

Tools Used

Manual Review

Recommendations

Add a check for tier amount in the upgradeTier function