Project

One World
NFTDeFi
15,000 USDC
View results
Submission Details
Severity: low
Invalid

Missing SafeERC20 Implementation in Factory Contract

Summary

The protocol exhibits an architectural inconsistency in its token transfer safety mechanisms. The Factory contract directly uses transferFrom without SafeERC20 wrapper, potentially causing failures with non-compliant ERC20 tokens. This oversight could lead to transaction failures and poor user experience.

Vulnerability Details

- MembershipFactory.sol lacks SafeERC20 implementation:

Impact

1. Token Integration Risks:

- Non-standard tokens will cause transaction failures - Platform functionality blocked for key tokens

2. User Experience Issues: - Failed transactions waste gas

- Inconsistent behavior across different tokens - Reduced protocol reliability

Tools Used

Manual Review

Recommendations

Implement OpenZeppelin's SafeERC20 wrapper functions in the Factory contract

Updates

Lead Judging Commences

0xbrivan2 Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Known issue
0xbrivan2 Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Known issue

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!