Project

Summary

the >= sign is chosen incorrectly, which leads to useless check in the upgradeTier() function.

Vulnerability Details

fromTierIndex is index which can be [0,1,2,3,4,5,6] as there can only be seven tiers. noOfTiersis presented in values [1,2,3,4,5,6,7]. Let's imagine that fromTierIndex = 6 and noOfTiers= 7. When checking require(daos[daoMembershipAddress].noOfTiers >= fromTierIndex + 1 .

The result of the check isfromTierIndex+1=7=noOfTiers.

The maximum allowable fromTierIndex may be 6.

Impact

an invalid tier will be added, which may lead to invalid behavior when calling the mint function

Tools Used

manual

Recommendations

use >instead >=