Project

Summary

The MembershipFactory contract provides functionality for creating and managing DAO memberships, including a fee charged to members when they join specific tiers. Currently, this contract lacks a mechanism for distributing a portion of this revenue to DAO creators, instead directing the entire joining fee toward platform wallets or DAOs themselves.

Vulnerability Details

Absence of Revenue Sharing for DAO Creators

The MembershipFactory contract establishes the following key aspects:

• DAO Creation: Allows users to create new DAOs with custom configurations and membership tiers.

• Member Fees: Charges fees to members who join various DAO tiers, with a portion allocated to a specified platform wallet for operational purposes.

However, there is no mechanism to allow DAO creators to receive a share of these fees.

https://github.com/Cyfrin/2024-11-one-world/blob/1e872c7ab393c380010a507398d4b4caca1ae32b/contracts/dao/MembershipFactory.sol#L145-L150

Impact

Without a share of the joining fees, DAO creators have limited direct financial motivation to continue managing or promoting their DAOs.

Tools Used

Manual analysis

Recommendations

Introduce a transparent mechanism within the MembershipFactory contract to split joining fees between the DAO creator and the platform wallet to enhance trust.