Project

One World
NFTDeFi
15,000 USDC
View results
Submission Details
Severity: medium
Invalid

No storage gap in MembershipERC1155

Summary

As we can see MembershipERC1155 is an upgradable account but there is no storage gap.

Vulnerability Details

https://github.com/Cyfrin/2024-11-one-world/blob/main/contracts/dao/tokens/MembershipERC1155.sol#L4

import "@openzeppelin/contracts-upgradeable/token/ERC1155/ERC1155Upgradeable.sol";
import "@openzeppelin/contracts-upgradeable/access/AccessControlUpgradeable.sol";
import "@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol";

Impact

in future,we may get storage collision .

Tools Used

Recommendations

induce storage gap for further to remove the likelihood of storage collision.

Updates

Lead Judging Commences

0xbrivan2 Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Known issue

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.