Project

Summary

Vulnerability Details

there is the link to the function

https://github.com/Cyfrin/2024-11-one-world/blob/1e872c7ab393c380010a507398d4b4caca1ae32b/contracts/dao/MembershipFactory.sol#L140

the mint call is used to mint a new membership token for the caller of the function, assigning it a specific tier or type based on tierIndex, but there is an issue using mint instead of safemint in erc1155 tokens, mint function does not verify whether the recipient can accept the token. If the recipient is a contract that does not implement the onERC1155Received function, the tokens could be lost or become inaccessible

there is the code

Impact

If the recipient is a contract that does not implement the onERC1155Received function, the tokens could be lost or become inaccessible

Tools Used

manual review

Recommendations

use safemint instead, because The safeMint function typically includes checks to ensure that the recipient can handle the token being minted,