The TierConfig struct includes a power field that is not utilized anywhere within the contract, rendering it effectively redundant. It implies functionality within the DAO membership setup that does not actually exist.
TierConfig is a struct designed to store configuration data for DAO membership tiers. Although the power member is part of TierConfig, it is neither referenced in any calculations nor utilized within the createNewDAOMembership or updateDAOMembership functions for setting and updating DAO configurations. Both of these functions perform important operations like checking tier limits and adjusting member counts, yet none of these operations leverage power.
The presence of the unused power field in TierConfig introduces unnecessary complexity and can lead to confusion. Developers or users interacting with the contract may assume that power has a functional purpose in the DAO membership configuration, potentially leading them to misunderstand how the contract operates.
Manual Review
Remove the unused power field from the TierConfig struct.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.