Project

One World
NFTDeFi
15,000 USDC
View results
Submission Details
Severity: low
Invalid

State Variable should Declared Immutable

Summary

The Lack of using of immutable variable at https://github.com/Cyfrin/2024-11-one-world/blob/1e872c7ab393c380010a507398d4b4caca1ae32b/contracts/dao/MembershipFactory.sol#L20

and https://github.com/Cyfrin/2024-11-one-world/blob/1e872c7ab393c380010a507398d4b4caca1ae32b/contracts/dao/MembershipFactory.sol#L19

could cause unnecessary gas during the execution of the contract.

Vulnerability Details

Using mutable variables instead of immutable ones can lead to unnecessary gas costs during contract execution.

Impact

This coould cause high gas.

Tools Used

manual review

Recommendations

it is recommended to use Immutable intead of mutable to save gas since it will only be called in constructor. use it like this

- address public owpWallet;
-address public proxyAdmin
+ address public immutable owpWallet;
+ address public immutable proxyAdmin
Updates

Lead Judging Commences

0xbrivan2 Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
0xbrivan2 Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.