Project
One World
NFTDeFi
15,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Potential underflow in `upgradeTier()` function when `fromTierIndex` is zero.

bajagasec

Summary

Potential underflow in upgradeTier() function when fromTierIndex is zero.

Vulnerability Details

In the upgradeTier() function, the following line may cause an underflow error if fromTierIndex is zero:

IMembershipERC1155(daoMembershipAddress).mint(_msgSender(), fromTierIndex - 1, 1);

When fromTierIndex is zero, fromTierIndex - 1 will result in an underflow, causing the function to revert.

Impact

If fromTierIndex is zero, the function call will revert due to underflow.

Tools Used

  • Manual Review

  • Visual Studio Code (VSCode)

Recommendations

Add a check to ensure fromTierIndex > 0 or revert with a custom error.

Updates

Lead Judging Commences

0xbrivan2 Lead Judge 12 months ago
Submission Judgement Published
Invalidated
Reason: Lack of quality
0xbrivan2 Lead Judge 12 months ago
Submission Judgement Published
Invalidated
Reason: Lack of quality

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.