Project

One World
NFTDeFi
15,000 USDC
View results
Submission Details
Severity: low
Invalid

There is no check in updateDAOMembership to ensure that the amount is not less than minted leading to incosistent state

Summary

when updateDAOMembership, it is possible for the new amount specified to be less than the amount that has already been minted

Vulnerability Details

Impact

inconsistent state where minted is more than max amount allowed

Tools Used

manual analysis

Recommendations

add a check to ensure that the new amount > already minted

for (uint256 i = 0; i < tierConfigs.length; i++) {
if (i < dao.tiers.length) {
tierConfigs[i].minted = dao.tiers[i].minted;
if(tierConfigs[i].amount < tierConfigs[i].minted) revert();
}
}
Updates

Lead Judging Commences

0xbrivan2 Lead Judge
12 months ago
0xbrivan2 Lead Judge 12 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.