Project
One World
NFTDeFi
15,000 USDC
View results
Previous Next
Submission Details
Severity: medium
Invalid

`burnBatch` and `burnBatchMultiple` cannot be called

inh3l

Summary

burnBatch and burnBatchMultiple are supposed to be callable by the factory, but the functions are non existent in the factory.

Vulnerability Details

When a new membershipNft is deployed, the DEFAULT_ADMIN_ROLE and OWP_FACTORY_ROLE are granted to msg.sender which is MembershipFactory.sol.

function createNewDAOMembership(DAOInputConfig calldata daoConfig, TierConfig[] calldata tierConfigs)
//...
TransparentUpgradeableProxy proxy = new TransparentUpgradeableProxy(
membershipImplementation,
address(proxyAdmin),
abi.encodeWithSignature("initialize(string,string,string,address,address)", daoConfig.ensname, "OWP", baseURI, _msgSender(), daoConfig.currency)
);
//...
}
_grantRole(DEFAULT_ADMIN_ROLE, msg.sender);
_grantRole(DAO_CREATOR, creator_);
_grantRole(OWP_FACTORY_ROLE, msg.sender);
}

But the contract lacks the a way to call the burnBatch and burnBatchMultiple functions. The contract also lacks a reasonable way to transfer the OWP_FACTORY_ROLE factory role to another user/contract so that the new actor can query the functions.

function burnBatch(address from) public onlyRole(OWP_FACTORY_ROLE) {
for (uint256 i = 0; i < 7; ++i) {
uint256 amount = balanceOf(from, i);
if (amount > 0) {
burn_(from, i, amount);
}
}
}
/// @notice Burn all tokens of multiple users
/// @param froms The addresses from which tokens will be burned
function burnBatchMultiple(address[] memory froms)
public
onlyRole(OWP_FACTORY_ROLE)
{
for(uint256 j = 0; j < froms.length; ++j){
for(uint256 i = 0; i < 7; ++i){
uint256 amount = balanceOf(froms[j], i);
if (amount > 0) {
burn_(froms[j], i, amount);
}
}
}
}

Impact

Functions cannot be accessed if needed and OWP_FACTORY_ROLE cannot be transferred to access the functions.

Tools Used

Manual Review

Recommendations

Add a relevant function in MembershipFactory contract

Updates

Lead Judging Commences

0xbrivan2 Lead Judge 12 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement
0xbrivan2 Lead Judge 12 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.