Project
One World
NFTDeFi
15,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

MembershipFactory.updateDAOMembership() does not emit event

elser17

Summary

MembershipFactory.updateDAOMembership() does not emit event

Vulnerability Details

EXTERNAL_CALLER may call MembershipFactory.updateDAOMembership() at a given time, which updates the tiers and their parameters for a DAO. This is a pretty relevant action in the system, because of that an event should be emitted to inform of this update.

Impact

Users or listeners cannot get informed of updates in DAOs' tiers, which is an important event in the protocol.

Tools Used

Manual review

Recommendations

Add a new event for the mentioned situation:

contract MembershipFactory is AccessControl, NativeMetaTransaction {
+ event UpdatedDAO(string indexed ensName, address nftAddress, DAOConfig daoData);
.
.
.
function updateDAOMembership(string calldata ensName, TierConfig[] memory tierConfigs){
.
.
.
+ emit UpdatedDAO(ensName, daoAddress, dao);
Updates

Lead Judging Commences

0xbrivan2 Lead Judge 12 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
0xbrivan2 Lead Judge 12 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.