Project

Summary

Vulnerability Details

https://github.com/Cyfrin/2024-11-one-world/blob/1e872c7ab393c380010a507398d4b4caca1ae32b/contracts/dao/MembershipFactory.sol#L140

in the joindao() user are to transfer the platformfee to owpWallet and also transfer the tierPrice - platformFees to the daoMembershipAddress before the get minted the token for the tierindex, but this function uses transferfrom instead safetransferfrom to transfer from msg.sender to the respective address and also do not handle failure in the logic, so if this transfer call fail due to some factore(e.g user not having enough balance) the function will not revert, it will still go ahead to mint the tokens to msg.sender

Impact

even if the transfer fails, the token of the specific tierindex will still be minted to the address provided by the caller

Tools Used

manual

Recommendations

implement logic to handle failure of transfer and also use safetransferfrom instead of transferfrom