Submission Details
Severity:
Passed `amount` in `MembershipERC1155::sendProfit` must be greater than zero
Summary
Passed amountt should be greater than 0.
Vulnerability Details
Passed amount in MembershipERC1155::sendProfit must be greater than zero, otherwise the transaction will be useless.
Impact
Gas usage without actual transfer.
Tools Used
Manual review
Recommendations
Add require to check if amount is greater than 0:
function sendProfit(uint256 amount) external {
uint256 _totalSupply = totalSupply;
// @audit amount must be greater than 0
+ require(amount > 0, "Amount must be greater than zero");
if (_totalSupply > 0) {
totalProfit += (amount * ACCURACY) / _totalSupply;
IERC20(currency).safeTransferFrom(msg.sender, address(this), amount);
emit Profit(amount);
} else {
IERC20(currency).safeTransferFrom(msg.sender, creator, amount); // Redirect profit to creator if no supply
}
}
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
54128 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.