Summary

The MembershipFactory contract has a hardcoded platform fee percentage (20%) in the joinDAO function. This design lacks flexibility for fee adjustments and transparency for users, potentially impacting protocol governance and user trust.

Vulnerability Details

In the MembershipFactory contract, the platform fee calculation is hardcoded to 20%:

This implementation has several issues:
1.No ability to adjust fees without contract upgrade
2.No transparency mechanism for users to query current fee rates
3.No event emitted when fees are collected

Impact

1.Protocol administrators cannot adjust fees based on market conditions
2.Reduced protocol flexibility and adaptability
3.Users cannot easily verify the current fee structure
4.Potential loss of user trust due to lack of transparency

Tools Used

Manual code review

Recommendations

1.Add fee adjustment mechanism
2.Add fee viewing functions for better transparency
3.Add the event emitted when fees are collected