Submission Details
Severity:
The incorrect termination condition of the for loop leads to gas wastage.
Summary
The incorrect termination condition of the loop leads to gas wastage.
Vulnerability Details
In the file MembershipFactory.sol, at line 114, a for loop assigns the value of dao.tiers[i].minted to tierConfigs[i].minted. The number of assignments depends on the variable dao.tiers.length,
for (uint256 i = 0; i < tierConfigs.length; i++) {
if (i < dao.tiers.length) {
tierConfigs[i].minted = dao.tiers[i].minted;
}
}
but the loop uses tierConfigs.length as the termination condition. This results in tierConfigs.length - dao.tiers.length unnecessary iterations.
Recommendations
for (uint256 i = 0; i < dao.tiers.length; i++) {
tierConfigs[i].minted = dao.tiers[i].minted;
}
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
54128 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.