Project

One World
NFTDeFi
15,000 USDC
View results
Submission Details
Severity: medium
Invalid

EXTERNAL_CALLER role in `MembershipFactory` can tamper with `MembershipERC1155` tokens

Summary

the function callExternalContract allows the user with the role EXTERNAL_CALLER to call any external contract.

the MembershipFactory is a privileged contract that can call mint and burn on MembershipERC1155 contracts.

https://github.com/Cyfrin/2024-11-one-world/blob/1e872c7ab393c380010a507398d4b4caca1ae32b/contracts/dao/MembershipFactory.sol#L176-L180

Impact

this allows the user with the role EXTERNAL_CALLER to tamper with the users MembershipERC1155 tokens.

Tools Used

manual audit

Recommendations

explicitly block function callExternalContract from calling any daoMembershipAddress

Updates

Lead Judging Commences

0xbrivan2 Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.