Project
One World
NFTDeFi
15,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Precision Loss Due To Incorrect Handling Of Tokens

momoweb3

Summary

given that USDC is a 6-decimal-token , WBTC is 8-decimals and WETH is 18, there will be precision loss leading to underpayment or overpayment of platform fees when dealing with smaller numbers in MembershipFactory .

https://github.com/Cyfrin/2024-11-one-world/blob/1e872c7ab393c380010a507398d4b4caca1ae32b/contracts/dao/MembershipFactory.sol#L144

Impact

protocol will either be underpayed or overpayed

Tools Used

manual review

Recommendations

add a constant precision calculation to handle calcualtions for each token

Updates

Lead Judging Commences

0xbrivan2 Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement
0xbrivan2 Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.