Project
One World
NFTDeFi
15,000 USDC
View results
Previous Next
Submission Details
Severity: medium
Invalid

joinDAO in MembershipFactory.sol will revert for low tier fees on some ERC20 tokens

copperscrewer

Summary

The platform fees can be zero if the tier fees are low, However this may revert certain ERC20s like LEND

d-xo/weird-erc20: weird erc20 tokens.

https://github.com/Cyfrin/2024-11-one-world/blob/1e872c7ab393c380010a507398d4b4caca1ae32b/contracts/dao/MembershipFactory.sol#L146

Vulnerability Details

Revert on low tier fees

Impact

joinDAO fails every time for the tier because of a technical revert in an edge case

Tools Used

manual analysis

Recommendations

wrap the transferFrom in a ifcondition so that it's executed only when the amount is non-zero

Updates

Lead Judging Commences

0xbrivan2 Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Out of scope
0xbrivan2 Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Out of scope

Appeal created

copperscrewer Submitter
10 months ago
0xbrivan2 Lead Judge
10 months ago
0xbrivan2 Lead Judge 9 months ago
Submission Judgement Published
Invalidated
Reason: Out of scope

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.